Skip to content

feat(ske): add ephemeral ske kubeconfig - #1448

Merged
SerseusWasTaken merged 3 commits into
stackitcloud:mainfrom
h3adex:feat/add-ephemeral-resource-ske-kubeconfig
Aug 20, 2026
Merged

feat(ske): add ephemeral ske kubeconfig#1448
SerseusWasTaken merged 3 commits into
stackitcloud:mainfrom
h3adex:feat/add-ephemeral-resource-ske-kubeconfig

Conversation

@h3adex

@h3adex h3adex commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds the stackit_ske_kubeconfig ephemeral resource. The default expiration has been reduced to 30 minutes. Since these credentials only need to persist for the duration of a Terraform run, where even slow Helm deployments rarely exceed a 10-15 minute window, a 60-minute expiration is excessive.

Tested example code:
https://professional-service.git.onstackit.cloud/professional-service-best-practices/professional-service/pulls/18

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@h3adex
h3adex requested a review from a team as a code owner May 8, 2026 08:22
@h3adex
h3adex marked this pull request as draft May 8, 2026 08:23
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch 2 times, most recently from e7a7211 to 21ffd96 Compare May 8, 2026 08:25
@h3adex h3adex mentioned this pull request May 8, 2026
Open
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 21ffd96 to 42e7091 Compare May 8, 2026 08:51
@h3adex

h3adex commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

don't review yet. E2E tests still open

@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch 9 times, most recently from 638204f to ad810c1 Compare May 11, 2026 11:24
@h3adex
h3adex marked this pull request as ready for review May 11, 2026 11:24
@h3adex

h3adex commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

E2E Tests
Screenshot 2026-05-11 at 14 00 48

@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch 3 times, most recently from cd6a220 to 0d06641 Compare May 18, 2026 06:23
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 0d06641 to 72e2165 Compare May 21, 2026 09:18
@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale PR is marked as stale due to inactivity. label May 29, 2026
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 72e2165 to 23b550f Compare May 29, 2026 09:21
@github-actions github-actions Bot removed the Stale PR is marked as stale due to inactivity. label May 30, 2026
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch 2 times, most recently from dd0520a to 08623d4 Compare June 5, 2026 11:47
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 08623d4 to 096316e Compare June 9, 2026 11:23
@github-actions github-actions Bot added the Stale PR is marked as stale due to inactivity. label Jul 16, 2026
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch 3 times, most recently from ea3a892 to cb934f4 Compare July 20, 2026 10:56
@github-actions github-actions Bot removed the Stale PR is marked as stale due to inactivity. label Jul 21, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale PR is marked as stale due to inactivity. label Jul 29, 2026
@rubenhoenle

rubenhoenle commented Jul 29, 2026

Copy link
Copy Markdown
Member

@h3adex Please resolve the comments you've already adressed 😅

@github-actions github-actions Bot removed the Stale PR is marked as stale due to inactivity. label Jul 30, 2026
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from cb934f4 to 60e1ae5 Compare August 3, 2026 08:55
@h3adex

h3adex commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

@rubenhoenle done

@rubenhoenle

rubenhoenle commented Aug 7, 2026

Copy link
Copy Markdown
Member

There are conflicts @h3adex

@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 60e1ae5 to 73df86b Compare August 10, 2026 09:38
@h3adex

h3adex commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

@rubenhoenle resolved conflicts

@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 73df86b to ee03b66 Compare August 13, 2026 10:58
@rubenhoenle
rubenhoenle force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from ee03b66 to e6312a1 Compare August 18, 2026 12:59
@rubenhoenle rubenhoenle removed the needs-work PR needs changes by the author. label Aug 18, 2026
rubenhoenle
rubenhoenle reviewed Aug 18, 2026
View reviewed changes
Comment thread stackit/internal/services/access_token/access_token_acc_test.go Outdated
rubenhoenle
rubenhoenle previously approved these changes Aug 18, 2026
View reviewed changes
@h3adex
feat(ske): add ephemeral ske kubeconfig
a08b081 
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from e1096c3 to a08b081 Compare August 18, 2026 14:58
@h3adex

h3adex commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Resolved last comment and squashed commits

@Pionerd Pionerd mentioned this pull request Aug 18, 2026
Open
SerseusWasTaken
SerseusWasTaken reviewed Aug 19, 2026
View reviewed changes
Comment thread stackit/internal/services/ske/kubeconfig/ephemeral_resource.go Outdated
@h3adex
update expiration docs
474abe3 
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
@SerseusWasTaken
SerseusWasTaken merged commit 76ef81b into stackitcloud:main Aug 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SerseusWasTaken SerseusWasTaken SerseusWasTaken approved these changes
@rubenhoenle rubenhoenle rubenhoenle left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@h3adex @rubenhoenle @SerseusWasTaken @GokceGK